search

joomla-framework / http

Joomla Framework Http Package
GNU General Public License v2.0
17 stars 21 forks source link

Don't include tests in composer distributions #31

Closed willemstuursma closed 3 years ago

willemstuursma commented 7 years ago

Tests are not needed when the package is installed as a dependency.

Pull Request for Issue #

Summary of Changes

Tests and test related files have been removed from the ZIP files that Composer downloads.

Testing Instructions

Create a new release, install via Composer and validate that Tests are excluded.

Documentation Changes Required

N/A

mbabker commented 7 years ago

So, while we've started doing this in some repos, there's actually a part of me that thinks we should either do it consistently all at once or not do it at all. Symfony actually did this for a short time then reverted it (https://github.com/symfony/symfony/issues/6605 for context). FWIW I support this, but I actually also see valid arguments for both removing and keeping.

@wilsonge have any thoughts?

willemstuursma commented 7 years ago

I guess Tobin hit it spot on here: https://github.com/symfony/symfony/issues/6605#issuecomment-60306001

nibra commented 3 years ago

Superseeeded by PR #41