search

joomla-framework / http

Joomla Framework Http Package
GNU General Public License v2.0
17 stars 21 forks source link

[2.0] Phase out deprecated `$php_errormsg` variable and `track_errors` use #44

Closed nibra closed 2 years ago

nibra commented 3 years ago

Summary of Changes

PHP 7.2 deprecates the track_errors INI configuration and the scoped $php_errormsg variable in favor of using the error_get_last() function for retrieving error data, and at PHP 7.0 using error_clear_last() to clear any errors (to my knowledge we aren't doing anything in core requiring the latter at the moment).

This PR phases out this deprecated functionality.

Testing Instructions

The packages should still function normally, including error handling (easiest way to test error handling is enable debug mode and language debug and break one of the language files with a parsing error).

nibra commented 3 years ago

Waiting for corresponding [1.x] change to be approved and merged, before this can be merged after an upmerge to regain sync.