search

joomla-projects / GSOC-Webdriver_system_tests_for_CMS

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla/joomla-cms | REPOSITORY NOT ANYMORE IN USE, see readme
https://github.com/joomla-projects/GSOC-Webdriver_system_tests_for_CMS/blob/staging/README.md
GNU General Public License v2.0
0 stars 3 forks source link

fix issue in MetaDescription change at frontend #115

Closed javigomez closed 9 years ago

javigomez commented 9 years ago

Fixes the test:

phpunit --verbose services/ConfigFrontEnd0002Test.php
PHPUnit 3.7.29 by Sebastian Bergmann.

Configuration read from /Users/javiergomez/Documents/joomla-vagrant/www/repos/GSOC-Webdriver_system_tests_for_CMS/tests/system/webdriver/tests/phpunit.xml.dist

.

Time: 13.88 seconds, Memory: 4.25Mb

OK (1 test, 20 assertions)
javigomez commented 9 years ago

@puneet0191 @kshitijSharma2014 please review and merge. Before there was a bit of mess, it used the AsertNotEquals to asert two equal values

puneet0191 commented 9 years ago

I would say a go! we can merge this, should I merge? @javigomez :+1: Thanks

puneet0191 commented 9 years ago

I am not understanding, as far as I know..that test was written in the first place to verify that the Meta Description should not change from the frontend, and that is what was the assertNotEquals was used for

javigomez commented 9 years ago

Updated, removing the redundant assertion.

javigomez commented 9 years ago

Not sure to understand your last comment, why Should I not be able to change the meta description?

screen shot 2015-02-05 at 17 20 43

puneet0191 commented 9 years ago

That was just a question, I was confused about it..I will ask Budhima

puneet0191 commented 9 years ago

merging for now! thanks @javigomez :+1: