search

joomla-projects / GSOC-Webdriver_system_tests_for_CMS

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla/joomla-cms | REPOSITORY NOT ANYMORE IN USE, see readme
https://github.com/joomla-projects/GSOC-Webdriver_system_tests_for_CMS/blob/staging/README.md
GNU General Public License v2.0
0 stars 3 forks source link

regarding extensions/LanguageManager0002Test #81

Open javigomez opened 10 years ago

javigomez commented 10 years ago

I see you haven't modified the names of the languages, they are still named "Test Filter 1" and " Test Filter 2". Please update them with a name more related with the test.

Also the test is not fixed, I still get:

..F

Time: 1.26 minutes, Memory: 6.00Mb

There was 1 failure:

1) LanguageManager0002Test::setFilter_TestFilters_ShouldFilterTags
Lang should be in row 2
Failed asserting that 1 matches expected 2.

/joomla-cms/tests/system/webdriver/tests/extensions/LanguageManager0002Test.php:140

FAILURES!
Tests: 3, Assertions: 84, Failures: 1.

But not sure that this is a proper way to test: "Lang should be in row 2"

@puneet0191 thoughts?

puneet0191 commented 10 years ago

yes, please update the assert statment, from equals to greater than @kshitijSharma2014

kshitijSharma2014 commented 10 years ago

@javigomez @puneet0191 I have fixed it in https://github.com/joomla-projects/GSOC-Webdriver_system_tests_for_CMS/pull/82

puneet0191 commented 9 years ago

This issue has been fixed, can we close this one @javigomez