search

joomla-projects / com_code

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla/developer.joomla.org for the current version.
0 stars 4 forks source link

Tags search button #14

Open Hutchy68 opened 9 years ago

Hutchy68 commented 9 years ago

So the chosen field works and js appears to be filtering the data. Problem, it can break easily on tags form field.

@nikosdion My question is in regards to the search button next to the tags form field, is it needed?

If a user clicks it, the return is "no data" and a blank table. It might be a bug in the way chosen js interprets the form submission pushing it back to a server-side call. Since the filtering is being done client side, the button forces server-side data extraction again (I think) and then returns null. Technically I think the data has already been sent, so the form field for tags shouldn't ask for it again.

Does this sound right? I think the only reason to have the button is to clear the form and resubmit the request to grab the unfiltered data again. Thoughts? I just don't know if we are grabbing all or using ajax to fill in the data and filter it as filters are applied.

To replicate the issue, go to http://developer.joomla.org/joomlacode-archive and select one of the trackers.

Only method is to remove all tags and select none then click the Search button next to it.

nikosdion commented 9 years ago

The button is not necessary. I honestly can't follow your train of thought as to what happens. Maybe just fire up Charles or Google Chrome Developer Tools and inspect the request? I can no longer test this component. The site I had built for it, with all of the sample data, was in the laptop that was stolen from me two weeks ago. I just don't have the time to rebuild it – at least not before mid June at the earliest.

Hutchy68 commented 9 years ago

Sorry it was late when I wrote it up. You can see the problem live on the developer.j site.

The gist is what and how much data is client side, all of it? If not all, what triggers the db call to pull in and filter more data? Not relevant if the search button can be removed because that's the element needed to cause the bug.