search

joomla-projects / com_localise

forked version of the original com_localise for experimental purposes
GNU General Public License v2.0
24 stars 36 forks source link

Github #244

Closed Skullbock closed 3 years ago

Skullbock commented 9 years ago

Added Github Sync. See #57

schermata 2014-11-08 alle 18 22 22

zero-24 commented 9 years ago

@Skullbock can you have a look into the CS issues mentioned by Travis:

Initializing PHP_CodeSniffer checks.
...........EEEEE.....................WW......
FILE: ...ild/joomla-projects/com_localise/component/admin/models/translation.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 196 | ERROR | Functions and classes must not contain multiple empty lines in a
     |       | row; found 2 empty lines
--------------------------------------------------------------------------------
FILE: ...ild/joomla-projects/com_localise/component/admin/models/packagefile.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 146 | ERROR | Doc comment for "$pk" missing
--------------------------------------------------------------------------------
FILE: ...s/build/joomla-projects/com_localise/component/admin/models/package.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 146 | ERROR | Doc comment for "$pk" missing
--------------------------------------------------------------------------------
FILE: ...build/joomla-projects/com_localise/component/admin/models/languages.php
--------------------------------------------------------------------------------
FOUND 8 ERROR(S) AFFECTING 8 LINE(S)
--------------------------------------------------------------------------------
 309 | ERROR | Instanciating new classes without parameters does not require
     |       | brackets.
 312 | ERROR | Please put a space between the // and the start of comment text;
     |       | found "//$options->set('gh.token', '');"
 313 | ERROR | Whitespace found at end of line
 316 | ERROR | Whitespace found at end of line
 321 | ERROR | Whitespace found at end of line
 325 | ERROR | Please consider an empty line before the return statement;
 327 | ERROR | Whitespace found at end of line
 328 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
FILE: .../build/joomla-projects/com_localise/component/admin/models/language.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 125 | ERROR | Doc comment for "$pk" missing
 372 | ERROR | Doc comment for "$pks" missing
--------------------------------------------------------------------------------
FILE: .../joomla-projects/com_localise/component/admin/controllers/languages.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 66 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: ...omla-projects/com_localise/component/admin/controllers/translations.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 38 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------

Also some checks fail. https://travis-ci.org/joomla-projects/com_localise/jobs/40430628

infograf768 commented 9 years ago

Also look at https://github.com/joomla-projects/com_localise/pull/242 I have some issues with it

Skullbock commented 9 years ago

Should've fixed the issues mentioned

javigomez commented 9 years ago

Thanks Daniele

Just mention that this is a proof of concept, if anyone has an idea of where to better place the button to fetch the language or a better name for it just say it. I'm aware that @Skullbock has in mind also to allow in the future to fetch specific tags of the different Joomla versions. That will be a great improvement, but for now we would like to concentrate on get this specific feature working and do more progress once is working.

infograf768 commented 9 years ago

Could you sync your branch as we did a few commits

infograf768 commented 9 years ago

@Skullbock also, can you solve this: https://github.com/joomla-projects/com_localise/pull/242

Note: I tested the part concerning getting en-GB from github and I get:

API rate limit exceeded for 2.2.50.217. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

Skullbock commented 9 years ago

@infograf768 i should've merged and resolved conflicts. Also, for github's api limitation, there is a todo there to allow adding the gh.token for using the higher rate limit instead of the free one.

infograf768 commented 9 years ago

( ! ) Notice: Undefined property: stdClass::$joomlacopyright in /Applications/MAMP/htdocs/trunkgitnew/administrator/components/com_localise/models/language.php on line 111

In fact Joomla!™ Copyright should always be present as these are the language xml files, not used by third party

therefore all works fine (for languages) when you take off the conditional if (!$data->joomlacopyright) {

infograf768 commented 9 years ago

oops posted in wrong PR

infograf768 commented 3 years ago

Obsolete