search

joomla-projects / com_localise

forked version of the original com_localise for experimental purposes
GNU General Public License v2.0
24 stars 36 forks source link

Improvements when saving translation file #290

Closed infograf768 closed 8 years ago

infograf768 commented 8 years ago

This PR adds: 1_ A confirm dialog when saving and save and close an edited ini file to remind user to set as desired the "Complete" field.

screen shot 2016-03-21 at 11 53 10

2_ A Notice, after saving the file, stating if the "Complete" status has been set or not.

screen shot 2016-03-21 at 11 53 56

3_ It changes the Complete field from a checkbox to a radio type yes/No

screen shot 2016-03-21 at 11 55 27

infograf768 commented 8 years ago

@Valc @andrepereiradasilva

To test, install the patched version of com_localise with 2 languages and edit one ini file from the Translations view (test with a non en-GB file).

Valc commented 8 years ago

Good idea. Here it is working fine.

andrepereiradasilva commented 8 years ago

@infograf768 IMHO i think we need to revise this repository structure so we can use the patchtester to test this repository PR. It will be a lot simpler to test PR.

I think what is need is to change the administrator folder, from "component/admin" to "administrator/components/com_localise" and update the files that reference that folder.

See the structure of the patchtester repository for more info https://github.com/joomla-extensions/patchtester