search

joomla-projects / com_localise

forked version of the original com_localise for experimental purposes
GNU General Public License v2.0
24 stars 36 forks source link

This repository does not work with Joomla patchtester #293

Open andrepereiradasilva opened 8 years ago

andrepereiradasilva commented 8 years ago

This repository does not work with Joomla Patchtester.

Joomla (https://github.com/joomla/joomla-cms) and patchtester (https://github.com/joomla-extensions/patchtester) works.

patchtester-config

The PR are fetched but cannot be applied.

I think the structure of the folders needs to be like the patchtester repository. In other words, i think what is need is to change the administrator folder, from "component/admin" to "administrator/components/com_localise" and update the files that reference that folder.

infograf768 commented 8 years ago

@javigomez

As I have not decided this structure, can you give us your feedback?

As it is now, to update my test site I use with eclipse "Build project" which uses a custom build.properties with the correct path to my test site.

And to create packs I use: ./phing -f /Users/mac/joomlatrunk/upstream_localise/build/build.xml

mbabker commented 8 years ago

For any extension to work with patchtester its repo MUST be structured like the CMS. The patchtester component didn't do anything special for that. When it tries to apply a patch, the check literally equates to "can we patch JPATH_ROOT/<file_path_specified_in_diff>".

infograf768 commented 8 years ago

@mbabker As you know, I did not structure this repo and I have absolutely no idea why it was not structured like the CMS. :smiley_cat:

mbabker commented 8 years ago

Personally I hate using that structure for extensions (how weblinks was structured before the test team started implementing their tools is closer to how I keep mine), but alas, that's the requirement to use the tool.