joomla-projects / com_localise

forked version of the original com_localise for experimental purposes
GNU General Public License v2.0
24 stars 36 forks source link

Why the "filter" input box is CASE sensitive? #305

Closed joomlagate closed 8 years ago

joomlagate commented 8 years ago

Steps to reproduce the issue

Today I tried to translate an extension named Snippets with com_localise. Snippets is downloaded from: https://www.regularlabs.com/extensions/snippets

After installation of this extension, I went to com_localise backend, and choose client and language, then input "Snippets" into the filter input box of com_localise. Nothing found.

Then I input all-lower-case word "snippets", I got some results.

Expected result

I think this filter function should be CaSe InSenSitIVe.

Actual result

But it is case insensitive, only allows complete lower case strings.

System information (as much as possible)

Joomla 3.5.1 PHP 7 com_localise 4.0.16 dev

Additional comments

Could you please let this filter function to be CaSe InSenSitIVe so that I can just copy the extension's name from that webpage and then paste it into the input box to search it, in this way, I think it can boost my effeciency than input a complete lower case sting MANUALLY.

Thank you.

infograf768 commented 8 years ago

@baijianpeng Can you test by replacing the file ROOT/administrator/components/com_localise/models/translations.php by this one (after decompressing):

translations.php.zip

joomlagate commented 8 years ago

Yes, this modified version works fine, now I can filter with any CasE combination.

Thank you.

白建鹏

https://www.joomlagate.com/

微信公众号:joomlagate 新浪微博: @joomlagate


2016-04-23 22:47 GMT+08:00 infograf768 notifications@github.com:

@baijianpeng https://github.com/baijianpeng Can you test by replacing the file ROOT/administrator/components/com_localise/models/translations.php by this one (after decompressing):

translations.php.zip https://github.com/joomla-projects/com_localise/files/232993/translations.php.zip

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/joomla-projects/com_localise/issues/305#issuecomment-213752604

infograf768 commented 8 years ago

Great, please add Test OK here: https://github.com/joomla-projects/com_localise/pull/306

infograf768 commented 8 years ago

Closing as we have a patch.