search

joomla-projects / custom-elements

A compilation of Joomla 4 Custom Elements.
GNU General Public License v2.0
32 stars 29 forks source link

test sauce labs tests #214

Closed dgrammatiko closed 1 year ago

dgrammatiko commented 1 year ago

DO NOT MERGE THIS!!!!!

dgrammatiko commented 1 year ago

B/C break: https://saucelabs.com/blog/update-firefox-tests-before-oct-4-2022 Waiting for https://github.com/karma-runner/karma-sauce-launcher/pull/278

wilsonge commented 1 year ago

I've had to directly commit the workflow stuff here because the tests wouldn't run anymore because of the higher node version required. At least the tests run in chrome again now which they didn't before.

dgrammatiko commented 1 year ago

Maybe I could try to use a patch (eg https://www.npmjs.com/package/patch-package) and get the Saucelabs tunnel in a working state. I'll have a look when I get home on both these PRs. The delay on both is due to the broken remote tests...

dgrammatiko commented 1 year ago

@wilsonge so I forked the karma-sauce-launcher and applied the PR and the remote tests are green again. Let me know if that's ok as a temp solution, till the upstream repo merges the https://github.com/karma-runner/karma-sauce-launcher/pull/278

wilsonge commented 1 year ago

https://github.com/karma-runner/karma-sauce-launcher/issues/275#issuecomment-1318593354 Are we able to stay with the original and use this workaround?

If not your fork is fine. We just need to document somewhere for the future in case they are able to magically deploy things.

dgrammatiko commented 1 year ago

@wilsonge applied the override, so no more forks. Merge it and let's see if it actually works

wilsonge commented 1 year ago

Looks good. Am I merging this one or you going to push to #215 this new part?

dgrammatiko commented 1 year ago

Merge this one, I have to review the other again (it's been a while and some pkgs might need another update)