search

joomla-projects / gsoc16_recording-action-logs

Recording actions logs, accessible by super admin
https://summerofcode.withgoogle.com/projects/#4547036649095168
GNU General Public License v2.0
4 stars 4 forks source link

Prepare the project for the core #37

Open muhakh opened 8 years ago

muhakh commented 8 years ago

Make the component and the plugin ready to be added to the Joomla core.

Robdebert commented 8 years ago

Oh yes, that's what i would love to also see :)

PS: Is this component extensible for plugings like K2 ?

muhakh commented 8 years ago

My approach is to add the sql queries in https://github.com/joomla-projects/gsoc16_recording-action-logs/blob/staging/plugins/system/userlogs/sql/install.mysql.utf8.sql to this file https://github.com/joomla-projects/gsoc16_recording-action-logs/blob/staging/installation/sql/mysql/joomla.sql

and add the component & plugin data as in this https://github.com/joomla-projects/gsoc16_recording-action-logs/blob/staging/installation/sql/mysql/joomla.sql#L486

What else is needed to make the project ready for the core?

roland-d commented 8 years ago

@muhakh You also need to provide the files for Postgresql and SQL Azure. In addition to that you need to create the update SQL files for all 3 storage engines in this folder: https://github.com/joomla-projects/gsoc16_recording-action-logs/tree/staging/administrator/components/com_admin/sql/updates That is for users who are updating and not doing a clean installation.

The file can be named 3.7.0-2016-08-24.sql

That should be it in terms of the SQL files.

yvesh commented 8 years ago

@muhakh And you still need to fix the codestyle on a lot of areas. Ping me if you need help with that.

muhakh commented 8 years ago

@yvesh I used phpcs and fixed the issues it showed me in the last PR. Are there any code style issues left?

yvesh commented 8 years ago

@muhakh yeah i fear so :(

Please check also my comments (there are other issues also) at https://github.com/joomla-projects/gsoc16_recording-action-logs/pull/39/files

@zero-24 Can you please help here with code style!

muhakh commented 8 years ago

Thanks @yvesh , I saw your comments and I'm fixing the code now.

zero-24 commented 8 years ago

Open points

SQL

Move the install part to te core install SQL https://github.com/joomla-projects/gsoc16_recording-action-logs/tree/staging/installation/sql

Same applys for the component there we need install and update SQL. This is something you can help with :) Ping me if you need help

PHP CS

I'm working on that now and prepare a PR for you to review.

zero-24 commented 8 years ago

There are just two places where you add code right? Just the plugin and the component?

muhakh commented 8 years ago

@zero-24 For the SQL part: What should I write for manifest_cache in this folder https://github.com/joomla-projects/gsoc16_recording-action-logs/tree/staging/installation/sql

As I find all extensions leave it empty

zero-24 commented 8 years ago

do it too :)