joomla-projects / gsoc16_recording-action-logs

Recording actions logs, accessible by super admin
https://summerofcode.withgoogle.com/projects/#4547036649095168
GNU General Public License v2.0
4 stars 4 forks source link

Suggesstion for the helper-file #38

Open Robdebert opened 8 years ago

Robdebert commented 8 years ago

https://github.com/joomla-projects/gsoc16_recording-action-logs/blob/staging/administrator/components/com_userlogs/helpers/userlogs.php#L17

Did you have a reason to make this class abstract? i think it should be a normal class, that can be invoked with $helper = new UserlogsHelper();

Then it is possible to use the constructor to define $this->lang = JFactory::getLanguage(); And then this is called only once, not for every row in $data in the loop in line #45 that calls translateExtensionName()

Robdebert commented 7 years ago

No answers on that topic?