search

joomla-projects / gsoc16_shareable-draft-content

Shareable Draft Content
https://summerofcode.withgoogle.com/projects/#5268339920207872
GNU General Public License v2.0
4 stars 2 forks source link

Database for shared drafts #10

Open nikitadhiman opened 8 years ago

nikitadhiman commented 8 years ago

The following fields are included;

  1. ID-primary key-unsigned
  2. Title
  3. Created
  4. Modified
  5. Share token
  6. Articleid-unsigned
roland-d commented 8 years ago

@nikitadhiman A few issues:

  1. You have comitted more files than that belongs to the Database definition. Please put them in a separate pull request
  2. You have made the pull request against the wrong branch. The pull request needs to be against the https://github.com/joomla-projects/gsoc16_shareable-draft-content/ repository
roland-d commented 8 years ago

@rishiv3 Does it look good to you?

rishiv3 commented 8 years ago

@roland-d Now everything looks good

zero-24 commented 8 years ago

Alter table for #__content is missing as well as installSQL? @nikitadhiman @roland-d @rishiv3 ?

roland-d commented 8 years ago

@zero-24 Yes the install SQL is still missing. What are you talking about in regards to the #__content table? That table is not being touched by this feature.

This PR needs updating anyway as the structure has changed since the last comment.

zero-24 commented 8 years ago

What are you talking about in regards to the #__content table?

There is a check for a colum share https://github.com/joomla-projects/gsoc16_shareable-draft-content/pull/14/files#diff-025610e4d30a6b7ffd43d2c55d0a9706R43

That needs to be removed than.

roland-d commented 8 years ago

@zero-24 That is the problem when looking at code that is not even alpha ready.