Closed nikitadhiman closed 8 years ago
@nikitadhiman Looks like you still haven't set up code style. Travis reports errors:
FILE: ...ft-content/administrator/components/com_content/controllers/article.php
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
147 | ERROR | You must use "/**" style comments for a function comment
155 | ERROR | Missing function doc comment
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
FILE: ...e-draft-content/administrator/components/com_content/models/article.php
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
708 | ERROR | You must use "/**" style comments for a function comment
711 | ERROR | Please start your comment with a capital letter; found "//
| | perform whatever you want on each item checked in the list"
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
FILE: ...ontent/administrator/components/com_content/views/article/view.html.php
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
130 | ERROR | No space found after comma in function call
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
@nikitadhiman Are you going to fix these issues?
@roland-d , on it....will ping you when done
@nikitadhiman Travis failed with the following issues: FILE: ...ft-content/administrator/components/com_content/controllers/article.php
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
150 | ERROR | Superfluous doc comment at position 1
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
FILE: ...e-draft-content/administrator/components/com_content/models/article.php
FOUND 11 ERROR(S) AFFECTING 10 LINE(S)
572 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
574 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
587 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
595 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
602 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
605 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
627 | ERROR | Cast statements must be followed by a single space; expected
| | "(array) $pks" but found "(array)$pks"
630 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...}\n...else "
644 | ERROR | Cast statements must be followed by a single space; expected
| | "(int) $value" but found "(int)$value"
649 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
| | (...)\n...{...} ...else "
649 | ERROR | Cast statements must be followed by a single space; expected
| | "(int) $value" but found "(int)$value"
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
Closing this in favor of #13 because this one is based on the wrong branch.
Pull Request is for creation of a share token and storing that token in the #__share_draft database.
Summary of Changes:
Testing Instruction:
Test 1 results: