search

joomla-projects / gsoc21_frontend-inline-editing

GNU General Public License v2.0
7 stars 2 forks source link

Global configuration option #7

Closed rs4231199 closed 3 years ago

rs4231199 commented 3 years ago

Added: A global configuration option to enable/disable inline editing

image

rs4231199 commented 3 years ago

@roland-d Please review this PR.

rs4231199 commented 3 years ago

@roland-d Is there any file that I skipped? Or is it good to merge?

roland-d commented 3 years ago

@rs4231199 It is good to go codewise. Just need to update this documentation page: https://docs.joomla.org/Help4.x:Site_Global_Configuration

Just no idea when we need to do that or where to write that down. Do you keep a list of documentation to update? If so, add this. If not, start it and add this :)

rs4231199 commented 3 years ago

I have planned to add functionality to quickly and temporarily disable inline editing by adding a URL parameter(for example, ?noinline=1). What are your thoughts on this? @roland-d @bembelimen @anibalsanchez

roland-d commented 3 years ago

I do not think we should add that. One setting for a feature is enough.

anibalsanchez commented 3 years ago

Agreed. Less is more.

rs4231199 commented 3 years ago

👍 I will merge it now.