search

joomla-projects / gsoc22_guided-tour

GNU General Public License v2.0
6 stars 6 forks source link

Featured & Locked #83

Closed brianteeman closed 1 year ago

brianteeman commented 1 year ago

Each tour has these three fields in the database but they dont appear to be used anywhere

aze088 commented 1 year ago

Notes was added in my latest build. As for the others, no idea.

brianteeman commented 1 year ago

Confirmed Notes is now used - title updated

obuisard commented 1 year ago

The 'locked 'column is used for tours that have language keys instead of plain text in their records. It allows tours in a multilingual environment to remain intact (a save would remove the language keys) and it will allow third party developers to also ship tours users cannot override but just duplicate, delete, archive or unpublish.

obuisard commented 1 year ago

The 'featured' column was added for a feature we have no time to put in: featured tours would have priority in the list of tours available for a run.

brianteeman commented 1 year ago

Locked: - so the intention is for the tours to be readonly? If so then I would expect the UI to have some sort of indicator to show that. BUT in all my tests with a locked tour I have not been restricted in what I can do so now i am confused

Featured: fair enough but then I would remove the field from the table. It can always be added if the feature is developed in the future

obuisard commented 1 year ago

I have removed those columns