search

joomla-projects / j4adminui

Joomla!4 alternative backend template
GNU General Public License v2.0
24 stars 18 forks source link

Fixed issue #133, templates file upload folder selection issue. #134

Open ahamed opened 4 years ago

ahamed commented 4 years ago

Pull Request for Issue #133 .

Summary of Changes

This pull request fixes template file upload modal's folder selection issue. And also improve scss.

Testing Instructions

Go to `Extensions > Templates > On Cassiopeia template click Edit Files > Click New File

Expected result

At the left side folder tree by clicking on a folder should select the folder and toggle its descendants.

Screenshot 2019-12-02 at 12 32 06 PM

Actual result

It reloaded the page by clicking on the folders.

Documentation Changes Required

brianteeman commented 4 years ago

The changes here can not be correct. You should not have to be making changes to the upstream files when they work perfectly with atum. The fact you need to change them is indicative of a problem in the template code and not in the system code

ahamed commented 4 years ago

We used joomla-modal Webcomponent instead of bootstrap modal and for that, we have to do this.

brianteeman commented 4 years ago

great that you are using the webcomponent but that doesnt change my comment

VanTrieuThanh commented 4 years ago

I don't see what happen when click on folder as: select the folder and toggle its descendants.

thaoredweb commented 4 years ago

Now, I can upload a new file but could not indicate the folder inside. It is in the root @ahamed07sajeeb b2 https://drive.google.com/file/d/1NoV3q6UX4OAqk8aIgNdnPc7NvZj5db9Y/view