Fixed issue #129, accessibility issue for add module to dashboard modal.

[ahamed]

Pull Request for Issue #129, #128.

Summary of Changes

This PR fixes accessibility issues of Add module to the dashboard modal. The following PR changes -

• Added aria-label attributes to the modal footer's Close and Save & Close buttons and remove unnecessary aria-hidden attributes from the buttons.
• Added aria-labelledby attribute on the module search input field.
• Added distinct aria-label for the Select module anchor tag.
• Added title attribute on the modal's iframe

Testing Instructions

Go to Dashboard and scroll to the bottom of the page and click Add modules to the dashboard button.

Expected result

The corresponding elements must havearia-* attributes.

Actual result

No aria-* attributes found.

Documentation Changes Required

[brianteeman]

On the modal view the select link have a class

On the regular view (administrator/index.php?option=com_modules&view=select&client_id=1) the select links have no class

is that intentional?

[ahamed]

It's not intentional, it's a mistake. The class is added there conditionally we need to add the class attribute inside the condition. I will fix it here.

[brianteeman]

does what it says

[ahamed]

does what it says

It's fixed.

[NguyenTrang091296]

I checked and I see aria-label has been updated for all "Select". But Modules page, It still mistake class.

[ahamed]

But Modules page, It still mistake class.

The class is needed only for the modal view. So we remove it from the module view. It's intentional.

[NguyenTrang091296]

But Modules page, It still mistake class.

The class is needed only for the modal view. So we remove it from the module view. It's intentional.

Yes. Tks!