Fix #113 issue: mod_quickicon missing strings #113

joomla-projects / j4adminui

Joomla!4 alternative backend template

GNU General Public License v2.0

24 stars 18 forks source link

Fix #113 issue: mod_quickicon missing strings #113 #153

Open davidnguyen-joomlashine opened 4 years ago

davidnguyen-joomlashine commented 4 years ago

Pull Request for Issue #113

Summary of Changes

Fix JText string

Testing Instructions

Expected result

Actual result

Documentation Changes Required

davidnguyen-joomlashine commented 4 years ago

@brianteeman I checked and see that "sr-only" presents actions: View all Users, View all Menu Items View all Articles and View all Modules, so I thought it makes sense if it is identical to text that be hidden from screen readers. Please let me know if I missed something. Thank you so much

brianteeman commented 4 years ago

Think about it for a second. Why would you hide text and then choose to display the exact same text

davidnguyen-joomlashine commented 4 years ago

@brianteeman I think it is not necessary, so it should be removed out. What do you think of my idea.

Thank you