search

joomla-projects / j4adminui

Joomla!4 alternative backend template
GNU General Public License v2.0
24 stars 18 forks source link

Fix issue #166: Badges' style in Privacy Status block at Dashboard is… #167

Open davidnguyen-joomlashine opened 4 years ago

davidnguyen-joomlashine commented 4 years ago

Pull Request for Issue #166 .

Summary of Changes

Change CSS class "text-" to "badge badge- " in administrator/modules/mod_privacy_dashboard/tmpl/default.php

Testing Instructions

Expected result

Actual result

Documentation Changes Required

kawshar commented 4 years ago

Please add a screenshot. That helps to visualize.

davidnguyen-joomlashine commented 4 years ago

@kawshar please have look at #166 issue to understand what I reported and fixed as well

Thank you

kawshar commented 4 years ago
Screenshot 2019-12-17 at 4 36 44 PM

It worked (Y)

simbus82 commented 4 years ago

The background made the status unreadable.

davidnguyen-joomlashine commented 4 years ago

@simbus82 what do you think of this style download

simbus82 commented 4 years ago

I don't think this ensure the compliance with AA WCAG 2.1, it's needed more contrast for the text vs background.

davidnguyen-joomlashine commented 4 years ago

Checked this style with WCAG Standard Screenshot (1)