search

joomla-projects / j4adminui

Joomla!4 alternative backend template
GNU General Public License v2.0
24 stars 18 forks source link

Fix issue #121: Logged in users #171

Open davidnguyen-joomlashine opened 4 years ago

davidnguyen-joomlashine commented 4 years ago

Pull Request for Issue #121 .

Summary of Changes

Made some changes in administrator/modules/mod_logged/tmpl/default.php

Testing Instructions

Expected result

Actual result

Documentation Changes Required

brianteeman commented 4 years ago

a better option would be to simply revert all the unnecessary changes that were made in this module and not introduce accessibility issues

davidnguyen-joomlashine commented 4 years ago

@brianteeman I'm not sure because HTML structure is total different from origin. Do you have another idea?

brianteeman commented 4 years ago

and that is the mistake. This template can not be an alternative template if it requires changes to the core markup. I keep saying this but none of you listen and you keep treating this as if it will be the only template and you can change everything.

davidnguyen-joomlashine commented 4 years ago

@brianteeman yes, I agreed with your idea. I will create an override for this module

davidnguyen-joomlashine commented 4 years ago

Reverted all change at core file and created an mod_logged override