search

joomla-projects / j4adminui

Joomla!4 alternative backend template
GNU General Public License v2.0
24 stars 18 forks source link

#173 #175

Open davidnguyen-joomlashine opened 4 years ago

davidnguyen-joomlashine commented 4 years ago

Pull Request for Issue #173 .

Summary of Changes

Add 'j-card', 'j-card-header', 'j-card-body' block styles on all tabs

Testing Instructions

Expected result

Actual result

Documentation Changes Required

C-Lodder commented 4 years ago

You are killing accessibility by replacing the <legend> with a <div>.

https://www.w3.org/TR/WCAG20-TECHS/H71.html#H71-description

The first element inside the fieldset must be a legend element, which provides a label or description for the group

brianteeman commented 4 years ago

Exactly what @C-Lodder says.

davidnguyen-joomlashine commented 4 years ago

Thanks for your comments. I inherit code from Global Configuration (https://recordit.co/i3JGWh8yrj) to show configure consistently on all tabs. Should we fix for 'Article' tab issue show as 'Global Configuration' tab? Thank you

brianteeman commented 4 years ago

Unfortunately the code in global configuration that you show here is also wrong. The layout being used layouts\joomla\content\options_default.php has been changed in this repo to completely break accessibility. Not your fault. It's just plain wrong. Despite a requirement and a commitment to make this accessible once again we see accessibility being broken.