All icon fonts missing - Githubissues

joomla-projects / j4adminui

Joomla!4 alternative backend template

GNU General Public License v2.0

24 stars 18 forks source link

All icon fonts missing #194

Closed brianteeman closed 4 years ago

brianteeman commented 4 years ago

Steps to reproduce the issue

Install the package from developer.joomla.org

All the icon fonts are missing due to this error

https://github.com/joomla-projects/j4adminui/blob/b3c7be543754a5d111c7fa2c25e668b771f74c1f/administrator/templates/khonsu/scss/fonts/_joomla-fonts.scss#L14-L15

kawshar commented 4 years ago

Did you run npm ci?

brianteeman commented 4 years ago

i am referring to the prebuilt zip

kawshar commented 4 years ago

I just installed and could not find any issue

Can someone please cross-check?

kawshar commented 4 years ago

@brianteeman you downloaded from this link, right? https://github.com/joomla-projects/j4adminui/files/4158949/Joomla_4.0.0-unofficial-khonsu-dev-Development-Full_Package.zip

brianteeman commented 4 years ago

This is the link that @marcodings gave and that I used https://developer.joomla.org/backend-template/

The same can be seen using this https://github.com/joomla/joomla-cms/issues/27758#issuecomment-582394630

You will almost certainly see on your local install that you have a build/media-source folder and thats why you have the font.

kawshar commented 4 years ago

I think the build was not correct.

brianteeman commented 4 years ago

That is why I wrote https://github.com/joomla-projects/j4adminui/issues/190#issuecomment-582416117

wilsonge commented 4 years ago

The build on jenkins uses the standard build script https://github.com/joomla-projects/j4adminui/blob/master/build/build.php should be reproducible - there's really nothing special happening in jenkins

It runs the command php build/build.php --remote=origin/master --exclude-gzip --exclude-bzip2 to generate the zips

exmmth commented 4 years ago

The build on jenkins uses the standard build script https://github.com/joomla-projects/j4adminui/blob/master/build/build.php should be reproducible - there's really nothing special happening in jenkins

Glad to see you! Thank you for you answer. We need do PR fix some files as I saw - #190

@kawshar I can try to do this PR I need you help to don't brake you "team build way".

@wilsonge in README different way to use this repo, this is promblem to need fix?

wilsonge commented 4 years ago

No - how we build the stable packages removes the developer dependencies required for local development. I can't see anything wrong with the readme.

How the files get fixed is one for the team here to work on :)