Fixed WCAG issues. - Githubissues

joomla-projects / j4adminui

Joomla!4 alternative backend template

GNU General Public License v2.0

24 stars 18 forks source link

Fixed WCAG issues. #60

Closed ahamed closed 4 years ago

ahamed commented 4 years ago

This Pull Request fixes the issues #50, #51, #53, #54, #56. Those all are WCAG issues.

This PR changes -

Administrator login panel's glossy Joomla! logo by flat colored Joomla! logo.
Contrast Ratio issue for installation step's hints texts and login button of the administrator login page.
Button's discernible text issues.

brianteeman commented 4 years ago

Several of the changes here break the usage of the atum template. This template is supposed to be an alternative template and not a replacement template. Everytime you do something to break atum you create more work later on.

brianteeman commented 4 years ago

Can you please close this pull request and submit one pull request per issue (unless obviously one change solves multiple issues). This makes it much easier to test and to track changes. It also makes it much quicker to test and merge as an error in one part does not prevent the other parts being merged.

ahamed commented 4 years ago

Can you please close this pull request and submit one pull request per issue (unless obviously one change solves multiple issues). This makes it much easier to test and to track changes. It also makes it much quicker to test and merge as an error in one part does not prevent the other parts being merged.

Those are small issues and are similar too. The merge could be postponed until all of them are fixed. And next PRs shall be individual for every issue.

brianteeman commented 4 years ago

It is bad practice and should be avoided.

https://medium.com/@fagnerbrack/one-commit-one-change-3d10b10cebbf

https://victoria.dev/blog/git-commit-practices-your-future-self-will-thank-you-for/