search

joomla-projects / j4adminui

Joomla!4 alternative backend template
GNU General Public License v2.0
24 stars 18 forks source link

Fixed issue #50, Elements must have sufficient color contrast. #73

Closed ahamed closed 4 years ago

ahamed commented 4 years ago

Pull Request for Issue #50.

Summary of Changes

These changes meet the contrast ratio threshold above 4.5:1.

davidnguyen-joomlashine commented 4 years ago

I checked the fix and the contrast ratio threshold is: 5.03:1 Screenshot (2)

As the expected result is 4.5:1 at here: #50, then you consider to use this value for "--icon-rgb": 110, 120, 129 (#6e7881) Screenshot (3)

ahamed commented 4 years ago

The contrast ratio threshold is 4.5:1. If it exceeds 4.5 then it's not a problem I think as it satisfied the threshold value. Correct me if I am wrong.

brianteeman commented 4 years ago

You are correct

davidnguyen-joomlashine commented 4 years ago

Hi ahamed07sajeeb,

If so, I confirmed your fix is ok.

Thank you