search

joomla-projects / joomla-browser

An extended Webdriver Browser to navigate through Joomla sites with Codeception
GNU General Public License v2.0
19 stars 35 forks source link

fix installExtensionFromFolder #218

Closed stell closed 2 years ago

stell commented 3 years ago

installExtensionFromFolder needed a pause cause it failed now and then when used in a workflow. Also added vscode to ignore

stell commented 3 years ago

Can this be merged?

richard67 commented 3 years ago

Have you noticed that the changes on GitHub show the complete src/JoomlaBrowser.php being changed because you have replaced all indentations with tabs by spaces?

Sorry, but this cannot be merged as it is.

richard67 commented 3 years ago

Looks ok now.

stell commented 3 years ago

How about merging? It was good to go.

Hackwar commented 2 years ago

I've compared your PR with the current codebase and it seems as if all your changes are already part of JoomlaBrowser. So I'm closing this one for now. If you think something important is still missing, please open a new PR. Please keep in mind that the codeformating has to stay. You can see issues with the codestyle by opening the link to the build in drone.

stell commented 2 years ago

installExtensionFromFolder still needs a second and getConfig is also missing. So nothing of the PR is withing the current codebase.

Hackwar commented 2 years ago

Thank you for your work. I've give it some polish and merged it.

stell commented 2 years ago

Thanks for merging. Will take care around CS next time.