fix the fail for the absense of the remove button

joomla-projects / joomla-browser

An extended Webdriver Browser to navigate through Joomla sites with Codeception

GNU General Public License v2.0

19 stars 35 forks source link

Closed rdeutz closed 3 years ago

rdeutz commented 3 years ago

This is a quick and a little bit dirty fix for the problem with the install button we faced just before we reaached the finish line for 4-stable

PhilETaylor commented 3 years ago

At first glance this looks like a step back as we are no longer testing the actual removal of the installation folder right?

the JS that triggers the removal of the folder is not being tested right?

We are also no longer testing the clicking of the red button in development mode right?

Also README.md in this repo will need updating where it refers to " - install Joomla removing Installation Folder"

wilsonge commented 3 years ago

Fixed this in several commits in a slightly cleaner way hopefully