search

joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 18 forks source link

Add check if certain metaData is already set #13

Closed coolcat-creations closed 8 years ago

coolcat-creations commented 8 years ago

If any metaData is already set by Template or somewhere else i added checks to see if it´s already set. In my test it works, please give advice if there is something wrong done.

mbabker commented 8 years ago

In theory this is right but the way we've structured this for the .org sites it's intended for this plugin to always set the metadata then the template to only set it if it isn't already set elsewhere. So it sounds like whatever site you're trying to use this with has another plugin or a component setting metadata separately.

On Saturday, September 3, 2016, designbengel notifications@github.com wrote:

If any metaData is already set by Template or somewhere else i added checks to see if it´s already set.

In my test it works, please give advice if there is something wrong done.

You can view, comment on, or merge this pull request online at:

https://github.com/joomla-projects/plg_content_joomlarrssb/pull/13 Commit Summary

  • Add check if certain metaData is already set

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joomla-projects/plg_content_joomlarrssb/pull/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWfoYjVFj4PKLWMTj4IjoK2EDwWZdEvks5qmYlqgaJpZM4J0UYD .

coolcat-creations commented 8 years ago

Ok great, thanks! So this workaround is ok but doesn´t match the J! Property workflow, right?

mbabker commented 8 years ago

Well it doesn't match the intent. Considering this still only works with com_content the only way you get this conflict is if you've got another plugin setting this same data or are using sh404. If you tweak the plugin ordering you could get around that.

On Saturday, September 3, 2016, designbengel notifications@github.com wrote:

Ok great, thanks! So this workaround is ok but doesn´t match the J! Property workflow, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joomla-projects/plg_content_joomlarrssb/pull/13#issuecomment-244551480, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWfobt3CYmR1W9ChZ0sZBirCZbwFB6Cks5qmYyogaJpZM4J0UYD .

coolcat-creations commented 8 years ago

I setup some parameters in a (non J! Property) Template for Social Media Meta Tags and want to use them as general and then the metas were set double. I have the possibility to disable some or all of the parameters in the template by so in this case the plugin would take over. Please don´t think that i use sh404 :-D

mbabker commented 8 years ago

Ahh. Well, while its a valid use case, it's not necessarily in line with how we've structured this for use on the J! Properties. Let me think this one over, since the plugin's main consumer is joomla.org I'm not too keen on adding too many "features" beyond the use case there.

On Saturday, September 3, 2016, designbengel notifications@github.com wrote:

I setup some parameters in a (non J! Property) Template for Social Media Meta Tags and want to use them as general and then the metas were set double. I have the possibility to disable some or all of the parameters in the template by so in this case the plugin would take over. Please don´t think that i use sh404 :-D

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joomla-projects/plg_content_joomlarrssb/pull/13#issuecomment-244552283, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWfoX0KFYZitPxoww1TMG5sXH1LLA3Uks5qmZBLgaJpZM4J0UYD .

coolcat-creations commented 8 years ago

Yes, i understand thanks!

mbabker commented 8 years ago

It's not causing any harm and improves compatibility with other stuff I guess. Merged.

coolcat-creations commented 8 years ago

thanks! :-)