search

joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 18 forks source link

Add ogimage width and height #23

Closed zero-24 closed 4 years ago

zero-24 commented 4 years ago

@coolcat-creations please confirm that this is what you had in mind here: https://github.com/joomla-projects/plg_content_joomlarrssb/issues/14

https://www.php.net/manual/en/function.getimagesize.php https://ogp.me/#structured

zero-24 commented 4 years ago

Would it make sense to add the mime type too?

og:image:type ? @coolcat-creations @conconnl ?

zero-24 commented 4 years ago

Here is a demo package that includes the changes of this PR for you to test @coolcat-creations

plg_content_joomlarrssb.zip

zero-24 commented 4 years ago

Also the latest commit is already included in the package and deployed.

conconnl commented 4 years ago

I have checked the output on one of our test sites.

This is the image in the article: image (1)

This was the output for that page: image

As we can conclude the OG Metadata shows the correct image size and image type.

zero-24 commented 4 years ago

Thanks @conconnl merging now.