search

joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 19 forks source link

No more display on category pages - Regression ? #24

Closed Sandra97 closed 4 years ago

Sandra97 commented 4 years ago

We used to have the sharing buttons displayed on the category pages. They are not there anymore...

Before: Screenshot_2020-08-31-Joomla-Official-News

conconnl commented 4 years ago

I have personally never seen them on the page https://www.joomla.org/announcements.html

This site also have some overrides, so I have to check what the problem really is. There were no changes by us on that level.

wilsonge commented 4 years ago

Almost certainly the issue michael mentioned here https://github.com/joomla-projects/plg_content_joomlarrssb/pull/20 @HLeithner you broke it basically :P

HLeithner commented 4 years ago

I only wrote the pr, I didn't merged it ;-) but at least now we know where to look for the problem

conconnl commented 4 years ago

Is this change even needed? I mean can we just revert it @zero-24 @HLeithner

HLeithner commented 4 years ago

It's related to a revert I have done before the release of a 3.9.17

zero-24 commented 4 years ago

Up to you @HLeithner I can do the revert of your PR here.

zero-24 commented 4 years ago

Reverted with https://github.com/joomla-projects/plg_content_joomlarrssb/commit/501ad4b347a6dc67e08c5020ba7e67341ba46c77 and released with 3.0.3

Thanks for the report 👍