search

joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 18 forks source link

Added article intro image as first priority for og image #6

Closed yvesh closed 8 years ago

mbabker commented 8 years ago

There's one other gotcha in this, otherwise at a first glance this looks pretty good.

In the layout the regex matches array is also used for Pinterest sharing (that's what the Always run this preg_match as the results are also used in the layout comment is referring to), so the layout will need to be changed to use your new $imageOg variable instead of the $matches array since that won't always be defined now.

yvesh commented 8 years ago

Fixed, sorry should read comments and not do 30 things at the same time..

mbabker commented 8 years ago

It's all good. That's what review and inline comments are for (mostly so I remember what features are there 😆 )