joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 19 forks source link

Email sharing doesn't seem to be behaving correctly #8

Closed Joomv closed 8 years ago

Joomv commented 8 years ago

When you click on the email share button and are using Outlook, you get the Title with + instead of spaces and a body call that stays in the subject line.

Changing line 25 of /plugins/content/joomlarrssb/tmpl/default.php from <a href="mailto:?subject=<?php echo urlencode($article->title); ?>body=<?php echo urlencode($itemURL); ?>"> to <a href="mailto:?subject=<?php echo ($article->title); ?>&amp;body=<?php echo urlencode($itemURL); ?>">

Appears to fix this.

mbabker commented 8 years ago

As long as the browsers all work OK without the subject URL encoded it's a good fix. I just don't want to break the browsers for the sake of good pre-filled subject lines in the email clients.

Joomv commented 8 years ago

I'll try and do some further testing. Even if the subject line is left as urlencoded, we need the & before the body call.

mbabker commented 8 years ago

Ampersand's added in now.