search

joomla-projects / plg_content_joomlarrssb

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons
10 stars 19 forks source link

Removed button check so it can still be used for og images #9

Closed yvesh closed 8 years ago

yvesh commented 8 years ago

Haven't noticed any issues without that so far

mbabker commented 8 years ago

That's how I know this plugin has broken single responsibility principle.

Move the check to the point just before the layout is actually rendered instead of removing it completely. There's still some markup in the layout not wrapped in conditionals that would be output even if you turned off every button.

mbabker commented 8 years ago

Actually, should be before the URL shortener is invoked. As those are only used in the share buttons. But definitely after all the metadata is processed that check should be in place.