Use an injected logger in the Task driver - Githubissues

joomla-projects / soc21_website-cronjob

GNU General Public License v2.0

5 stars 3 forks source link

Use an injected logger in the Task driver #56

Closed ditsuke closed 2 years ago

ditsuke commented 2 years ago

Pull Request for Issue #17 .

Summary of Changes

A logger is injected into Task at creation, and into routines through ExecutedTaskEvent at runtime.

Testing Instructions

Tasks should be logged as expected to the scheduler log file @ administrator/logs/joomla_scheduler.php
Logs for individual tasks, if enabled, should be saved to the file as specified in the configuration.

Actual result BEFORE applying this Pull Request

No DI, ugly setup code in TaskPluginTrait etc.

Expected result AFTER applying this Pull Request

DI, less static calls (still depends on the global Log instance to setup sub-loggers!), more succinct code.

Documentation Changes Required

-