joomla-projects / soc21_website-cronjob

GNU General Public License v2.0
5 stars 3 forks source link

Fix pagination with orphan task filter #57

Closed ditsuke closed 2 years ago

ditsuke commented 2 years ago

Summary of Changes

Pagination in the task manager was broken because we were filtering out orphaned tasks from a limited list. To solve this, we could either filter out orphans from a fully loaded tasks list or do the filtering within the query by passing all active routines queries through task plugins. I chose the latter approach, which should fix this issue.

Testing Instructions

Test the pagination by adding items, orphaning some creating tasks by disabling the parent plugins.

Actual result BEFORE applying this Pull Request

Pagination is broken.

Expected result AFTER applying this Pull Request

Pagination should work as expected.

Documentation Changes Required

-