joomla-x / joomla-pythagoras

Joomla Pythagoras Repository
19 stars 20 forks source link

Remove FOF 2 #66

Closed laoneo closed 8 years ago

laoneo commented 9 years ago

FOF needs to be removed in J4 in favor of the new architecture and to not confuse developers to have multiple ways to build their extensions..

How should FOF being deprecated in Joomla 3? Would it be enough to add a deprecate message in that file https://github.com/joomla/joomla-cms/blob/staging/libraries/fof/include.php as it would be too much effort to add a deprecate message to every single file?

dgrammatiko commented 9 years ago

I think it is already deprecated, just do pr that removes the folder and the composer stuff...

dgrammatiko commented 9 years ago

Also mind https://github.com/joomla/joomla-cms/blob/staging/libraries/cms.php#L42-L46

zero-24 commented 9 years ago

@dgt41 we have core functions that works with fof postinstall & TFA they will stop working also. Fof is also in the com_admin script (cleaning the fof cache)

nikosdion commented 9 years ago

com_postinstall needs to be rewritten – if we're keeping it at all. Most users ignore the messages anyway.

TFA only uses the TOTP library in FOF. You can simply pry it away from FOF and put it in libraries/cms

As for clearing the fof cache, obviously this is no longer an issue if you remove FOF ;)

mbabker commented 9 years ago

Ironically some people do read them. A lot of questions on the forum after 3.4.0 after the robots.txt and htaccess changes.

zero-24 commented 9 years ago

yes i just what to mention that it is not only remove the fof folder.

nikosdion commented 9 years ago

Amazing. So this feature I first tried on my software and ported to Joomla! actually worked on Joomla! far better than it worked on my own software? LOL!

wilsonge commented 9 years ago

It's just scaleability dude :P More Joomla Users = More people asking questions :P

laoneo commented 8 years ago

With the clean base approach, this becomes obsolete.