search

joomla / 40-backend-template

Joomla 4.0 Backend Template Repository
GNU General Public License v2.0
14 stars 6 forks source link

Fix alert z-index #372

Closed ciar4n closed 6 years ago

ciar4n commented 6 years ago

Pull Request for Issue #370 .

Summary of Changes

Alert z-index to low. This PR increases

Testing Instructions

Save article. Ensure alert appears.

dgrammatiko commented 6 years ago

I think 1041 is ok here

brianteeman commented 6 years ago

Replicated the issue and can confirm this PR fixes it

brianteeman commented 6 years ago

Correction - it fixes the issue with the alerts in com_content but it breaks the modals in com_finder eg when you press index. see screenshot

chrome_2018-04-17_23-33-53
brianteeman commented 6 years ago

actually looks like it is a problem with all modals

chrome_2018-04-17_23-37-04
ciar4n commented 6 years ago

@brianteeman Thank you. I believe this issue was present before this PR (https://github.com/joomla/joomla-cms/issues/19408).

The issue (as I see it) is the modal markup follows directly after the element that triggers it (eg. index button). So if a triggers container has a z-index, the modal will inherit it. Hence why this issue depends on where the modal was triggered.

ciar4n commented 6 years ago

I think 1041 is ok here

I try to keep within the bootstrap scale of 1000 - 1100 in units of 10 for lightboxes/modals.

brianteeman commented 6 years ago

ok

dgrammatiko commented 6 years ago

I try to keep within the bootstrap scale of 1000 - 1100

Isn't that thing customisable in the _viariables.scss ? I mean is there a reason to keep these hideous values?

ciar4n commented 6 years ago

I mean is there a reason to keep these hideous values?

There is some logic to them when dealing with lightboxes/modals as they should be above everything else. I'm happy changing it if you feel strongly against them.

ciar4n commented 6 years ago

@dgrammatiko Is it possible to move the modal markup to just inside the closing body tag to resolve the issue indicated by @brianteeman ? Maybe you know of another solution?

dgrammatiko commented 6 years ago

Is it possible to move the modal markup to just inside the closing body tag

I'll do that for the joomla-ui-components but not for the bootstrap one (no time for both)

ciar4n commented 6 years ago

Don't do anything yet. Probably an easier way around it. I'll have a closer look later.

ciar4n commented 6 years ago

I have reshuffled the z-index so the modal works in most cases. There is one instance that I can't get around and that is when the modal is triggered from the toolbar. This issue is also present in Joomla 3 although not as obvious. Issue create.. https://github.com/joomla/joomla-cms/issues/20255