[WIP] SVG Icons - Githubissues

joomla / 40-backend-template

Joomla 4.0 Backend Template Repository

GNU General Public License v2.0

14 stars 6 forks source link

[WIP] SVG Icons #441

Closed dgrammatiko closed 6 years ago

dgrammatiko commented 6 years ago

Pull Request for Issue # .

Summary of Changes

Bye bye font-awesome font, welcome font-awesome svgs

Testing Instructions

screen shot 2018-06-05 at 16 40 49

Documentation Changes Required

brianteeman commented 6 years ago

brianteeman commented 6 years ago

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href

dgrammatiko commented 6 years ago

@brianteeman what browser are you using here?

brianteeman commented 6 years ago

Chrome on Windows

PS are you sure this works in IE?

dgrammatiko commented 6 years ago

IE is very picky on svgs but there is a way to have the same icons rendered without too much hustle. But before we get to that point there are couple things that needs to be resolved first:

Right now icons are an array in the document, I guess this needs to be either in HTMLHelper or a Library?
Outputing the html in the template can be done either the way I'm doing it here, (unlikely) or introducing a new <jdoc:include type="icons" /> (or something similar)
Getting the icons from the FA repo and adding the specific IDs (plus some more inline attributes to make IE11 happy, stroke="currentColor" etc)

@mbabker @wilsonge can you point me to the right direction for the first 2 issues?

dgrammatiko commented 6 years ago

@brianteeman oh by the way I figured out why you're not getting the icons, your instance is in a subdirectory...

mbabker commented 6 years ago

@dgrammatiko life would be so much easier if we mandated Joomla can only run at root of public_html 🤣

brianteeman commented 6 years ago

Or if @dgrammatiko developed in a sub directory because he always makes the same mistake

brianteeman commented 6 years ago

and would it not be better to use the svg sprites instead of individual svg?

dgrammatiko commented 6 years ago

Sprites packaged by font awesome will get us back to where we were with the font. The idea here is:

decouple from font awesome
able to override an icon in a similar fashion to scripts and stylesheets
Joomla is doing the packaging here (ok we're not really packaging things here but that might be a milestone 2, if we want to go this way)

brianteeman commented 6 years ago

Not going to ask what is wrong with being coupled to the font

Not sure if we can repackage the fonts under the licence - you would need to check that

dgrammatiko commented 6 years ago

@brianteeman as always I have no clue what's the compatibility of licenses but according to their repo the license is

- Icons — CC BY 4.0 License
     In the Font Awesome Free download, the CC BY 4.0 license applies to all icons packaged as .svg and .js files types.

brianteeman commented 6 years ago

ah - they';ve removed the restriction about bundling and packaging

brianteeman commented 6 years ago

still no change for me :(

brianteeman commented 6 years ago

Still no change :(

wilsonge commented 6 years ago

After our 30 minute group skype discussion I'm going to close this.

wilsonge commented 6 years ago

Discussions outcomes:

Font awesome coupling in the backend
Inline SVGs in the frontend templates where required. Possibly coupling to font awesome on a per view basis (the backend template)