Closed dgrammatiko closed 6 years ago
@brianteeman what browser are you using here?
Chrome on Windows
PS are you sure this works in IE?
IE is very picky on svgs but there is a way to have the same icons rendered without too much hustle. But before we get to that point there are couple things that needs to be resolved first:
<jdoc:include type="icons" />
(or something similar)@mbabker @wilsonge can you point me to the right direction for the first 2 issues?
@brianteeman oh by the way I figured out why you're not getting the icons, your instance is in a subdirectory...
@dgrammatiko life would be so much easier if we mandated Joomla can only run at root of public_html
🤣
Or if @dgrammatiko developed in a sub directory because he always makes the same mistake
and would it not be better to use the svg sprites instead of individual svg?
Sprites packaged by font awesome will get us back to where we were with the font. The idea here is:
Not going to ask what is wrong with being coupled to the font
Not sure if we can repackage the fonts under the licence - you would need to check that
@brianteeman as always I have no clue what's the compatibility of licenses but according to their repo the license is
- Icons — CC BY 4.0 License
In the Font Awesome Free download, the CC BY 4.0 license applies to all icons packaged as .svg and .js files types.
ah - they';ve removed the restriction about bundling and packaging
still no change for me :(
Still no change :(
After our 30 minute group skype discussion I'm going to close this.
Discussions outcomes:
Pull Request for Issue # .
Summary of Changes
Bye bye font-awesome font, welcome font-awesome svgs
Testing Instructions
Documentation Changes Required