Closed ciar4n closed 6 years ago
We have a php notice here - this is because in the definitions the icons are associated with the items not the headers. Needs a small tweak to get that working.
We need to think about how this looks on screens too - because even on my large pc screen (30 odd inches) - this is going off the edge of my screen. On my macbook screen you can only see the outer edge of the 4th column
Still a big improvement tho! Looking good!
4 columns is probably a bit adventurous
@brianteeman that was the design given
@ciar4n @wilsonge about the notification: I guess I included icons for each menu but not for the headers :(
@wilsonge i think its going off your screen just because of the error as without the error i cant replicate
Currently this isnt completely matching the issue #430 as the view is the same at all screen sizes
Yup - but in the designs none of the actual items have icons (aside from messages). So I guess it's best to do have arrays with: name
, icon
, links
where links is the current array.
For now I have removed the icons. Maybe someone with a little more smarts than I, could add them back in on another pr.
4 columns should be fine on most screen sizes. I suspect the overflow issue is related to the long strings in the php error. I added some media queries for the column count on smaller screens.
Before
After