Closed rogercreagh closed 2 weeks ago
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.
โฑ๏ธ Estimated effort to review: 2 ๐ต๐ตโชโชโช |
๐งช No relevant tests |
๐ No security concerns identified |
โก No key issues to review |
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.
Category | Suggestion | Score |
Typo |
Fix a spelling error in the explanation of where the menu link is added___ **Correct the spelling of "manifest" in the sentence explaining where the menu link isadded during installation.** [versioned_docs/version-5.1/building-extensions/components/quicktasklink.md [17]](https://github.com/joomla/Manual/pull/310/files#diff-be6a5b8a4f4d358dd096ce2967b5dc74883b240b9dde1f3cb62bc5982b5b010dR17-R17) ```diff -Your menu link is added in the manfest file during installation. +Your menu link is added in the manifest file during installation. ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion correctly identifies and fixes a spelling error in the word "manifest," improving the clarity and professionalism of the documentation. | 9 |
Fix a spelling error in the explanation of default icon usage___ **Correct the spelling of "components" in the sentence explaining the default iconusage.** [versioned_docs/version-5.1/building-extensions/components/quicktasklink.md [37]](https://github.com/joomla/Manual/pull/310/files#diff-be6a5b8a4f4d358dd096ce2967b5dc74883b240b9dde1f3cb62bc5982b5b010dR37-R37) ```diff -The default icon is the '+' sign indicating create a new item as this is the most common usage in the built-in compponents. +The default icon is the '+' sign indicating create a new item as this is the most common usage in the built-in components. ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion correctly identifies and corrects a spelling mistake in the word "components," enhancing the readability and correctness of the documentation. | 9 | |
โ Correct the spelling in the XML code block title for consistency___Suggestion Impact:The spelling of "Qicktask" was corrected to "Quicktask" in the XML code block titles. code diff: ```diff -```xml title="Qicktask Link and title" - - +```xml title="Quicktask Link and title" + ``` -NB the title translation string needs to appear in the language `.sys.ini` file for the extension +The title translation string needs to appear in the language `.sys.ini` file for the extension ## Quicktask Icon -The default icon is the '+' sign indicating create a new item as this is the most common usage in the built-in compponents. +The default icon is the '+' sign indicating create a new item as this is the most common usage in the built-in compponents. -You can specify a different icon, either as a simple name for the built in common aliased icons (the `icon-` prefix will be automatically added), or as the font-awesome specification. +You can specify a different icon, either as a simple name for the built in common aliased icons (the `icon-` prefix will be automatically added), or as the font-awesome specification. -```xml title="Qicktask Link and icon" - - +```xml title="Quicktask Link and icon" +consistency with the rest of the document.** [versioned_docs/version-5.1/building-extensions/components/quicktasklink.md [23]](https://github.com/joomla/Manual/pull/310/files#diff-be6a5b8a4f4d358dd096ce2967b5dc74883b240b9dde1f3cb62bc5982b5b010dR23-R23) ```diff -```xml title="Qicktask Link and title" +```xml title="Quicktask Link and title" ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: The suggestion addresses a spelling error in the XML code block title, ensuring consistency and accuracy throughout the document. | 8 |
That change needs to be done in /docs (and additional in versioned-docs) but /docs is the important version for such changes
That change needs to be done in /docs (and additional in versioned-docs) but /docs is the important version for such changes
So does that require a separate PR - I assumed if I just edit from the published page it would update all copies which would be sensible?
thx
User description
Correct spelling typo in "Quicktask link" sub -head
Changed Quicktask link section text to refer to title which appears as a mouseover the icon, and to state that the language string needs to be in the .sys.ini lanuage file
Added new sub-section Quicktask Icon with explanation and example.
Added fontawesome icon example to the Example section
NB there is also a tag but I can find no information how to use it.
PR Type
documentation
Description
.sys.ini
file.Changes walkthrough ๐
quicktasklink.md
Update Quicktask Link Documentation with Icons and Titles
versioned_docs/version-5.1/building-extensions/components/quicktasklink.md
.sys.ini
files.