joomla / accessibility

Collaboration to implement accessbility into Joomla
8 stars 12 forks source link

Report: Explore the Backend Login page #41

Open zwiastunsw opened 6 years ago

zwiastunsw commented 6 years ago

The Backend login page has passed the accessibility tests (thanks Yannick Berges). Although the page is accessible, several issues need to be considered and possible adjustments should be made.

Inadequate title of page

Page TITLE element does not describe its function or purpose. The title of the page shall be 'Administrator'. In fact it is the "Login page" (or "Login to the Backend"). See:

How to fix it If a higher level description is necessary for the user to understand the function or purpose of the controls within the fieldset, provide this description within the legend. If this description or grouping is not necessary, the fieldset should probably be removed. See:

Ask for comments, suggestions or patches and PR submissions.

brianteeman commented 6 years ago

Re fieldsets and legends

It is required that the fieldset and legend are used conjuction. A fieldset cannot be used without a legend and visa versa. (by Steve Faulkner, The Pacciello Group)

This is outdated as it refers to the html4.1 specification. The html5 specification does not make it a requirement. see https://www.w3.org/TR/html52/sec-forms.html#elementdef-fieldset

This was also confirmed to me by the Drupal accessibility lead AND Leonie Watson of the Pacciello Group

zwiastunsw commented 6 years ago

I agree. The HTML 5.2 specification does not specify that the two elements have to be present together. The legend is an optional element. There was no such condition in the HTML 4.1 specification either.

The legend element provides a name for the fieldset element. Without the legend element, the fieldset element does not have a name. The name describes the purpose of the fieldset, making it easy for the user to understand. If there is no name, the purpose of the fieldset element is unclear. This raises the question of whether this element is needed at all. That is why I wrote: If this description or grouping is not necessary, the fieldset should probably be removed.

The earlier specifications (HTML 4.1) explicit stated that the legends improve accessibility, especially for users of assistive technologies.

The FIELDSET element allows authors to group thematically related controls and labels. Grouping controls makes it easier for users to understand their purpose while simultaneously facilitating tabbing navigation for visual user agents and speech navigation for speech-oriented user agents. The proper use of this element makes documents more accessible. The LEGEND element allows authors to assign a caption to a FIELDSET. The legend improves accessibility when the FIELDSET is rendered non-visually. HTML 4.01 Specification. 17.10 Adding structure to forms: the FIELDSET and LEGEND elements.

That is why I continue to maintain my opinion.

I will be happy to hear a different opinion and argument on this issue.

brianteeman commented 6 years ago

Can you tell me where the tabindex is please - I don't see it

zwiastunsw commented 6 years ago

Hi, already fixed. https://github.com/joomla/joomla-cms/pull/21088

brianteeman commented 6 years ago

ok - and I just fixed the title https://github.com/joomla/joomla-cms/pull/21603/

brianteeman commented 6 years ago

As there is only a login box on this page I don't think there is a need for a < main > but I will add it if you think its needed

zwiastunsw commented 6 years ago

I also have a problem with that. But because:

It is a best practice to include ALL content on the page in landmarks, so that screen reader users who rely on them to navigate from section to section do not lose track of content.

I think it is no mistake to add the main role here. But it will not be a violation if we don't add it, either.

brianteeman commented 6 years ago

its a 2 second thing so i will do that in the morning

brianteeman commented 6 years ago

Re main landmark https://github.com/joomla/joomla-cms/pull/21604

brianteeman commented 6 years ago

Is there anything left to do for this?

zwiastunsw commented 5 years ago

@micker : Please, test