joomla / accessibility

Collaboration to implement accessbility into Joomla
8 stars 12 forks source link

"Search Form or Search Results" menu item: Form elements must have labels #67

Closed eddiekonczal closed 3 years ago

eddiekonczal commented 5 years ago

[XX x.x.x] Descriptive Title

"Search Form or Search Results" menu item: Form elements must have labels I am unsure what to put for XX and x.x.x

Description of the issue

When using the Deque WorldSpace plugin for Chrome to test a "Search Form or Search Results" menu item (with "Use Search Options" turned on), the following accessibility violation is reported:

Form elements must have labels

What happens

When using the Deque WorldSpace plugin for Chrome to test a "Search Form or Search Results" menu item (with "Use Search Options" turned on), the following accessibility violation is reported:

Form elements must have labels Issue description Ensures every form element has a label

Impact: critical Learn more Element location input[autocomplete="off"] Element source

To solve this violation, you need to: Fix at least one (1) of these issues: aria-label attribute does not exist or is empty

aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty

Form element does not have an implicit (wrapped)

Form element does not have an explicit

Element has no title attribute or the title attribute is empty

See screenshot:

search-form-missing-label

What do you expect

No violations should be reported.

Steps to reproduce

Create a "Search Form or Search Results" menu item On the "Options" tab of the menu item, set "Use Search Options" to "Yes" Test the menu item with Deque WorldSpace plugin for Chrome

How to fix (in case you know what needs to be changed)

Krshivam25 commented 3 years ago

Hi, @eddiekonczal I would like to contribute to this please help me to get started.

eddiekonczal commented 3 years ago

Hi, @Krshivam25 - it appears this issue was resolved in Joomla! 3.9.9.

See: https://github.com/joomla/joomla-cms/pull/24623 https://github.com/joomla/joomla-cms/issues/25127

Thanks for following up! -Eddie