search

joomla / backend-template

backend template for Joomla 4 working area
GNU General Public License v2.0
13 stars 23 forks source link

A11y quickicons div #341

Closed chmst closed 5 years ago

chmst commented 5 years ago

Pull Request for Issue #115 .

Summary of Changes

Until now, quickicons are implemented as unordered lists. Somo the if the list elements habe two links, one the overview, one to the edit form. The screenreader cannot "see" this and counts a wrong number of elmments in the list.

Here the elements are implemented as links, but not as list. The screenreader announces a navigation, but does not count the elements.

@brianteeman, @zwiastunsw - your opnion please? In this POC the question is only if it is acceptable to have a wrong counting of ist elements or if it is better to have a navigation without list. The css is not in sccope of this pr. Additionally it is no problem to add a sr-only information about the number of entries to every module.

brianteeman commented 5 years ago

until @zwiastunsw comments about the count are addressed this is futile to me

brianteeman commented 5 years ago

The screenreader counts the correct number of items in the list. It is broken by the markup having 1 or more links for each item. that in itself is an a11y failure. Each item should be its own list item

brianteeman commented 5 years ago

but to answer the question no this div solution is not ok as you must know how many items there are

chmst commented 5 years ago

as I said,: Additionally it is no problem to add a sr-only information about the number of entries to every module. I'll see later what I can do

brianteeman commented 5 years ago

I dont think that will be acceptable

brianteeman commented 5 years ago

See this original report by @zwiastunsw https://github.com/joomla/joomla-cms/issues/20995