search

joomla / backend-template

backend template for Joomla 4 working area
GNU General Public License v2.0
13 stars 23 forks source link

No matching results - duplicated #344

Closed brianteeman closed 5 years ago

brianteeman commented 5 years ago

Steps to reproduce the issue

In the menu manager do a silly filter that will produce no results

Expected result

A single message "no matching results"

Actual result

You get the message twice image

Additional comments

This is fine in the main repo I tested com_content and it didnt happen there

brianteeman commented 5 years ago

found the problem - PR incoming I hope

brianteeman commented 5 years ago

sorry - no idea why this is happening in this repo and not in the main repo

I can say that one message is coming from https://github.com/joomla/backend-template/blob/f0d19edf2580e11aaf713d5449452ef87e89c9de/administrator/components/com_menus/forms/filter_items.xml#L30 and one message from https://github.com/joomla/backend-template/blob/f0d19edf2580e11aaf713d5449452ef87e89c9de/administrator/components/com_menus/tmpl/items/default.php#L48-L51

bembelimen commented 5 years ago

Yes, the search layout outputs the message if https://github.com/joomla/backend-template/blob/release/administrator/components/com_menus/forms/filter_items.xml#L30 is set. So no need for https://github.com/joomla/backend-template/blob/release/administrator/components/com_menus/tmpl/items/default.php#L49-L52

(So the XML for every list view should be updated and the message removed from the tmpl layout)

bembelimen commented 5 years ago

I created a PR. Thx.