search

joomla / backend-template

backend template for Joomla 4 working area
GNU General Public License v2.0
13 stars 23 forks source link

monochrome #348

Closed brianteeman closed 5 years ago

brianteeman commented 5 years ago

monochrome only partially works as large parts are still in color. I am guessing that its because those elements still in color have a real color defined in the css and not a variable.

if thats correct then its going to be a lot of work for someone to go through all the css and change the colors to vars and that wont work for extensions

If my understanding is correct then you can look at some js to do this. I had hoped to use an accessibility javascript and one of its options was to make everything gray. It works by using filters (i think) . Anyway it works. Maybe you can borrow that js and use it instead of this complex php that doesnt look like it can ever work 100%

https://github.com/joomla/joomla-cms/pull/24112

brianteeman commented 5 years ago

BTW the only reason we havent merged the accessibility script was because it has no persistance across pages and upstream is not responding. @wilsonge and I agreed we will probably fork the plugin but it wasnt urgent. I dont think either of us realised you could possibly use it here

nadjak77 commented 5 years ago

The colors like "success" or "danger"... should be still in color. I think they are "important" to see, so they stay in color. But you are right, there were some colors who should change to monochrome. I changed the definition so they change now. You can see it in the branch tmp_colorhelper.

brianteeman commented 5 years ago

Maybe your concept of the reason for this are very different to mine

nadjak77 commented 5 years ago

Could you please explain a bit more where you see the problems? Thanks

brianteeman commented 5 years ago

If I chose an option called monochrome then I would expect everything to be monochrome.

chrome_2019-07-07_13-20-56 chrome_2019-07-07_13-21-25 chrome_2019-07-07_13-21-50
zwiastunsw commented 5 years ago

@nadjak77 write:

The colors like "success" or "danger"... should be still in color. I think they are "important" to see, so they stay in color.

That's the wrong approach! Monochromatic colours are for people who have difficulty distinguishing colours (colour blindness). If you have a monochrome version, it has to be a full monochrome version. In general, the weighting of a message only in colour is not accessible. Another visual indicator must be used, e.g. an icon.

brianteeman commented 5 years ago

This can be closed as it has been correctly resolved