style the button for toggling the toolbar on mobile

joomla / backend-template

backend template for Joomla 4 working area

GNU General Public License v2.0

13 stars 23 forks source link

style the button for toggling the toolbar on mobile #359

Closed nadjak77 closed 5 years ago

nadjak77 commented 5 years ago

Pull Request for Issue # .

Summary of Changes

set a-tag to button-tag style as button

Testing Instructions

Expected result

shoult be btn-secondary and aligned in center

Actual result

Documentation Changes Required

brianteeman commented 5 years ago

font icon <span class="icon-wrench"></span> This should be the same as all the other uses of font-icon <span class="icon-wrench" aria-hidden="true"></span

I appreciate that the text is "toolbar" and that makes sense but the wrench icon is really more for tools/utilities/options. If you dont want to use a burger icon here then how about https://fontawesome.com/icons/caret-square-down?style=solid

nadjak77 commented 5 years ago

I added the aria-hidden=true. For the icon I chose the chevron-down because we use almost everywhere icons without background. I hope this is fine for you