search

joomla / backend-template

backend template for Joomla 4 working area
GNU General Public License v2.0
13 stars 23 forks source link

Hide menu items when feature disabled or missing permissions #365

Closed Hackwar closed 5 years ago

Hackwar commented 5 years ago

Pull Request for Issue #226 .

Summary of Changes

Workflow and custom fields are hidden in dashboards when the feature is disabled for a component. It is also checked if you have permission to com_config, com_privacy, com_actionlogs, com_admin and com_joomlaupdate

Testing Instructions

  1. Check that custom fields and workflow are displaying for com_content in the dashboard/left side menu.
  2. Disable custom fields or workflow
  3. Notice that the menu item is removed in the menu both left and in dashboard.
Hackwar commented 5 years ago

@brianteeman Maybe have a look?

brianteeman commented 5 years ago

will put it on my todo for tomorrow - also see https://github.com/joomla/joomla-cms/pull/23366

brianteeman commented 5 years ago

Tested disabling not testing acl com_content - fields ✔️ com_content - workflow ✔️ com_users - fields ✔️ com_users - mass mail (disabled in global configuration) This is removed from the main menu but not from the submenu (dashboard)

Hackwar commented 5 years ago

added massmail as well. @bembelimen when the tests pass, can you merge this then?