joomla / backend-template

backend template for Joomla 4 working area
GNU General Public License v2.0
13 stars 23 forks source link

Quickicon a11y blocks #400

Closed chmst closed 5 years ago

chmst commented 5 years ago

For quickicons several issues and comments were open.

Summary of Changes

-> All Buttons now are list elements < li > -> If two buttons belong to the same component (list view and edit view), they are in a list < ul >. The screenreader NVDA seems to read this correct.

-> The text on Add-Buttons is now the verb "Add" instead of "New". -> From now on, the number can be switched off and on for all icons (also cache and checkin).

Every help for further improving accessibility of quickicons is highly appreciated.

brianteeman commented 5 years ago

Will try to take a look tomorrow

chmst commented 5 years ago

thx

chmst commented 5 years ago

@brianteeman would be great if you could have a look here.

You wrote that the code is completely broken, could you please define what is broken and what you think would be a solution?

brianteeman commented 5 years ago

I tried but got this error when running npm

Error: Undefined variable: "$quickicon-color-hover".
        on line 60 of administrator/templates/atum/scss/blocks/_quickicons.scss, in mixin `@content`
        from line 35 of media/vendor/bootstrap/scss/mixins/_hover.scss, in mixin `hover-focus-active`
        from line 58 of administrator/templates/atum/scss/blocks/_quickicons.scss
        from line 34 of administrator/templates/atum/scss/template.scss
>>           color: $quickicon-color-hover;
   -----------------^

Looks like you deleted the variable from administrator/templates/atum/scss/_variables.scss

chmst commented 5 years ago

Did you run npm build:css?

brianteeman commented 5 years ago

That is the error from npm

The problem is this commit https://github.com/joomla/backend-template/commit/ef27ec65b39f499e6b79470c103fe0699a9dd72a where you removed the variable definition but did not remove the use of the variable

chmst commented 5 years ago

Sorry, I need new glasses.

brianteeman commented 5 years ago

The site module gives a11y errors

Issue: