search

joomla / cassiopeia

Home of the Cassiopeia frontend template working group for version 4 of the Joomla! Content Management System
GNU General Public License v2.0
7 stars 16 forks source link

Improvement on font-family and font-size for editor.css #246

Closed drmenzelit closed 3 years ago

drmenzelit commented 3 years ago

Pull Request for Issue #233 .

Summary of Changes

Change font-family and font-size in templates/system/editor.css font-family is like in Bootstrap a long list of system fonts font-size is now in rem not in px

Testing Instructions

Edit an article in frontend or backend, you should see the difference in font size

Expected result

Font is bigger as before

richard67 commented 3 years ago

This will solve the issue only if font scheme "None" is selected in the template style options. If any other font scheme is applied, the fonts in frontend and in the editor in backend will again be different.

drmenzelit commented 3 years ago

Because the editor is in an iFrame, it can "read" what is outside coming from the template. Importing Bootstrap / template things will bloat the file unnecessarily. If the user wants to have all template definitions in the editor, he/she can load the template.css or another special editor.css file in the configuration on the TinyMCE plugin.

richard67 commented 3 years ago

@hans2103 Could you review this one here? Thanks in advance.

chmst commented 3 years ago

I am not sure if it is a good idea to change the editor.css of the system. woudn't it be better to add an editor.css to cassiopeia?

brianteeman commented 3 years ago

@chmst If there were/are any specific cassiopeia changes then you are correct it should be in an editor.css for cassiopeia. However it looks like all of these are just modernisations and belong in the system editor.css

Ideally cassiopeia should ship with an editor.css to serve as an example (even if its not really needed perhaps). The editor.css has always been a bit of a hidden secret and we should give it more exposure.

chmst commented 3 years ago

It was my intention that we have an editor.css as example in cassiopeia. But this is then another PR.