search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Add SCSS Coding Standards #146

Closed C-Lodder closed 7 years ago

C-Lodder commented 7 years ago

This PR adds the coding standards for SCSS, in addition to some minor tweaks for CSS

photodude commented 7 years ago

Should we also list LESS here as well?

C-Lodder commented 7 years ago

I can't see how we can add coding standards for LESS as the J3.x files are absolutely diabolical and we don't use them in 4.0

photodude commented 7 years ago

According to how I read it, the existing standards suggest the LESS files should have followed the CSS standards and the nesting like SCSS

but with no enforcement of the standards, no one followed them.

zero-24 commented 7 years ago

I'm not sure here. The coding standards with scss are only valid for 4.0 for 3.x we still have LESS as default so we can apply this change before 4.0 is live :smile:

photodude commented 7 years ago

Considering LESS will be alive and supported in the 3.x branch for like the next 2 years we should include that in the standard even if the files are not actually compliant with the expected code style.

C-Lodder commented 7 years ago

Once the LESS standards have been applied, someone will then have to apply those standards. Whoever does that....well all I can say is good luck and enjoy.

mbabker commented 7 years ago

@C-Lodder Would you be able to redo this PR against the master branch? We've dropped the gh-pages branch and using GitHub pages for the manual in favor of showing it through a component on https://developer.joomla.org.

C-Lodder commented 7 years ago

sure, will do tomorrow

C-Lodder commented 7 years ago

@mbabker done: https://github.com/joomla/coding-standards/pull/155